Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable epicea monitoring during mutant evaluation #55

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Disable epicea monitoring during mutant evaluation #55

merged 3 commits into from
Dec 21, 2023

Conversation

DurieuxPol
Copy link
Collaborator

Code changes is not polluted by the mutants.

@DurieuxPol DurieuxPol changed the title Disable epicea during mutant evaluation Disable epicea monitoring during mutant evaluation Dec 20, 2023
guillep
guillep requested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DurieuxPol and @Inao0!
Now, this PR will have a conflict with the other one :).
Even worse, since the other one repeats code, this would go unnoticed and only change the runMutant method but not the duplicated version (that runs all without stopping on errors).
This is why it is important to avoid repeating code => otherwise fixes should go in all duplicated code!

I propose to fix first the other PR that is more complicated, then come back to this one and fix the conflict. What do you think?

@DurieuxPol
Copy link
Collaborator Author

I fixed the other PR, now I will fix the conflict.

@coveralls
Copy link

coveralls commented Dec 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7289151262

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 228 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-3.5%) to 56.85%
Files with Coverage Reduction New Missed Lines %
src/MuTalk-Model/MutantEvaluationResult.class.st 3 90.0%
src/MuTalk-Model/MutantEvaluationResultKilled.class.st 3 56.92%
src/MuTalk-Model/ReplaceSelectBlockWithAlwaysFalseBlockOperator.class.st 3 66.67%
src/MuTalk-Model/ReplaceSelectBlockWithAlwaysTrueBlockOperator.class.st 3 66.67%
src/MuTalk-Model/TestCaseReference.class.st 3 57.78%
src/MuTalk-Tests/MethodMutationTest.class.st 3 97.56%
src/MuTalk-CI/AbstractCoverageInfoPreparation.class.st 4 0.0%
src/MuTalk-Model/MutantEvaluation.class.st 4 58.18%
src/MuTalk-Tests/MockMutationTestingAnalysisLogger.class.st 11 63.33%
src/MuTalk-Model/MethodMutation.class.st 25 73.73%
Totals Coverage Status
Change from base Build 7289139568: -3.5%
Covered Lines: 3639
Relevant Lines: 6401
💛 - Coveralls

guillep
guillep approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good now! Thanks all!

@guillep guillep merged commit 1d2aad4 into pharo-contributions:master Dec 21, 2023
3 checks passed
@DurieuxPol DurieuxPol deleted the enh/workWithIona branch February 5, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillep guillep guillep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DurieuxPol @coveralls @guillep